Conversation
|
Aight, the go tests are passing, so that's what matters |
|
cc @parrt |
|
Maybe @davesisson @pboyer @willfaught could take a look and bless the changes. |
|
Okie, thanks |
willfaught
left a comment
willfaught
left a comment
There was a problem hiding this comment.
I got a few files in and then noticed how many changes there are. I won't be able to cover it all in one day. Hopefully the others can pitch in too. :)
|
Aight, that should do it |
|
Hi @Joakker it looks like we are getting a Go language failure: |
|
Oop, will fix in the morning |
| } | ||
|
|
||
| func NewBaseATNConfig1(c ATNConfig, state ATNState, context PredictionContext) *BaseATNConfig { | ||
| // ATNConfigWithStateContext creates a new instance of BaseATNConfig. |
There was a problem hiding this comment.
I wonder if these comments actually add anything. I don't know go very well at all but it seems like these comments are not adding very much to constructor functions.
There was a problem hiding this comment.
Actually, they look like useless comments because they don't give additional information, don't explain how an algorithm works, etc.
|
seems like a huge change; perhaps @jcking or someone more knowledgeable can scan through but many of those comments seem unnecessary to me per my comment I just made. |
|
Guys trying to clean up. I think I'll close as there is controversy here. sorry! |
4 participants
Partially addresses #2504 (comment)
This PR normalizes the doc comments in the go runtime sources to one more compatible with the go documentation tool,
godoc, so the auto-generated docs over at pkg.go.dev look more readable, since people familiar with go will look there first for the documentation instead of in this repo.It also hides some elements that don't need to be exported as they don't have to do strictly with the generated parser.